Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install latest patch release when given a major.minor pair. #226

Closed
jthegedus opened this issue Sep 6, 2017 · 3 comments
Closed

Install latest patch release when given a major.minor pair. #226

jthegedus opened this issue Sep 6, 2017 · 3 comments

Comments

@jthegedus
Copy link
Contributor

jthegedus commented Sep 6, 2017

Steps to reproduce

asdf install nodejs 6.10

Expected behavior

asdf should install the latest patch version for a given major.minor version.

Actual behavior

An error occurs which states:

•100% ➔ asdf install nodejs 6.10
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  6748    0  6748    0     0   4629      0 --:--:--  0:00:01 --:--:--  4628
gpg: no valid OpenPGP data found.
gpg: the signature could not be verified.
Please remember that the signature file (.sig or .asc)
should be the first file given on the command line.
Authenticity of checksum file can not be assured! Please be sure to check the README of asdf-nodejs in case you did not yet bootstrap trust. If you already did that then that is the point to become SUSPICIOUS! There must be a reason why this is failing. If you are installing an older NodeJS version you might need to import OpenPGP keys of previous release managers. Exiting.

Environment

OS: Ubuntu Gnome 17.04

asdf version: 0.2.1

[edit] - Thanks for the amazing tool! I am keen to help! I'm not familiar with this type of codebase but could be useful given some direction. Thanks!

@Stratus3D
Copy link
Member

This isn't supported in asdf, but it could be added to asdf and asdf-nodejs. Though this is something the individual plugin could support on it's own. I'm not really sure what logic belongs in asdf and what logic belongs in the plugins. I'm thinking maybe we just take all the flags the users passes to asdf install and pass them to plugins install callback script, that way the plugin can make the necessary decisions when finding the right version. This would allow us to do things like:

asdf install nodejs 6.10 --latest

This is related to #216. We should probably tackle that feature before starting this.

@mwean
Copy link
Contributor

mwean commented Mar 2, 2018

I think it would be great if asdf would always operate on the highest matching version. For example, I just went to install erlang, and I know that I need something in the 19 range, so I tried to do asdf install erlang 19 which failed.

It would be great if this functionality could be handled for all plugins rather than implementing it for each plugin separately. Is that possible?

@Stratus3D
Copy link
Member

Closing this since there as been more recent discussion on #352.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants