Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add common layers for the crawl, keyphrase, and socket applications #57

Open
ashley-evans opened this issue Nov 27, 2021 · 0 comments
Open
Labels

Comments

@ashley-evans
Copy link
Owner

Value Added

Completes transition from old project structure to new monorepo structure using lerna. Reduces code duplication.

Description

As part of #55 a common crawl layer was introduced that contained common code that was used across all of the crawl lambda functions.

Similar duplication exists across the remaining applications, specifically in each of the function's constants.js file. Therefore, similiar changes should be made to reduce the code duplication further.

Acceptance Criteria

AC01

  • Update each of the remaining applications with their own common layers that contain all common code used across that application.

AC02

  • Update socket application template to use crawl common layer for obtaining crawl constants rather than duplicating code.

AC03

  • Changes required to ensure the lambda functions continue to function should be achieved by SAM/CloudFormation template updates
@ashley-evans ashley-evans added the 2 label Nov 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant