Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed issue #48 where the headers were not being set for async exceptions. #50

Closed
wants to merge 3 commits into from
Closed

Fixed issue #48 where the headers were not being set for async exceptions. #50

wants to merge 3 commits into from

Conversation

lahsuk
Copy link

@lahsuk lahsuk commented Sep 21, 2020

fixed #48

@ashleysommer
Copy link
Owner

ashleysommer commented Sep 21, 2020 •
edited
Loading

Hi @lahsuk
I wrote out a comment on this thread today but it didn't save.
I'll quote it in here:

Hi. Thanks for the PR.
I've added a comment in the code review above.
Are you sure the problems seen in #48 is due to async exceptions?
I don't think @ray-t1 or @syntaxkim mentioned they are/were using async exception handlers.

@misuzu
Copy link

misuzu commented Mar 10, 2021

I don't know about async exceptions, but this fixes CORS issues when using sentry-sdk.

@ashleysommer
Copy link
Owner

Closing because this is no longer relevant on the latest version of Sanic-CORS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashleysommer ashleysommer ashleysommer left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow-Control-Access-Origin header duplicated or none present in headers.
3 participants
@lahsuk @ashleysommer @misuzu