Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cutout overlays #348

Open
ddobie opened this issue Mar 10, 2022 · 1 comment
Open

Update cutout overlays #348

ddobie opened this issue Mar 10, 2022 · 1 comment
Assignees
Labels
enhancement New feature or request on hold Feature currently not being worked on but still wanted

Comments

@ddobie
Copy link
Collaborator

ddobie commented Mar 10, 2022

@Andywang201605 has pointed out that there is now a package that correctly handles plotting sky regions in spherical projections - https://astropy-regions.readthedocs.io/en/stable/index.html.

We could update Source._gen_component_overlays to use astropy-regions.EllipseSkyRegion, which would be much simpler. However this may be a case of "if it ain't broke, don't fix it".

@ddobie ddobie added the enhancement New feature or request label Mar 10, 2022
@ddobie ddobie self-assigned this Mar 10, 2022
@ajstewart
Copy link
Collaborator

Probably be good to revisit this once it has been merged into the astropy core package - as is their intended aim.

@ddobie ddobie added the on hold Feature currently not being worked on but still wanted label Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request on hold Feature currently not being worked on but still wanted
Projects
None yet
Development

No branches or pull requests

2 participants