Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider input validation to loss functions #1

Open
asmith26 opened this issue Jul 1, 2020 · 0 comments
Open

Consider input validation to loss functions #1

asmith26 opened this issue Jul 1, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@asmith26
Copy link
Owner

asmith26 commented Jul 1, 2020

We have currently/intentionally not added input validation and exception raising to loss functions to prevent potential performance loss. It could be beneficial to explore mechanisms (e.g. potentially via python decorators) for adding this.

Validations suggestions:

  • test_raises_error_when_any_y_true_and_y_pred_lengths_different
  • For losses that expect a probability input (between 0 and 1).
    • test_raises_error_when_y_true_not_sum_1
    • test_raises_error_when_y_pred_not_sum_1
    • test_raises_error_when_any_y_pred_le_0
    • test_raises_error_when_any_y_pred_gt_1
@asmith26 asmith26 added the enhancement New feature or request label Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant