From 8fef916aa5485485d81a24e6de69e565f7cde27b Mon Sep 17 00:00:00 2001 From: Greg Magolan Date: Wed, 30 Nov 2022 15:10:24 -0800 Subject: [PATCH] chore: bump to Bazel 6.0.0rc3 (#671) --- .bazelversion | 5 +---- README.md | 6 +++--- 2 files changed, 4 insertions(+), 7 deletions(-) diff --git a/.bazelversion b/.bazelversion index 48085cfad..d40d3713f 100644 --- a/.bazelversion +++ b/.bazelversion @@ -1,7 +1,4 @@ -0d2b4d67eefa2e3cd3f8f2374fc8a2a9c766d268 -# NB: commit hash here is temporary until Bazel 6.0.0rc3 or 6.0.0 final are out (which ever is next). -# using last_green fails sometimes if the commit hash it resolves to doesn't yet have an bazel -# artifact available for download +6.0.0rc3 # The first line of this file is used by Bazelisk and Bazel to be sure # the right version of Bazel is used to build and test this repo. # This also defines which version is used on CI. diff --git a/README.md b/README.md index fe5d70a09..9b868b1f2 100644 --- a/README.md +++ b/README.md @@ -14,9 +14,9 @@ Google does not fund development of rules_js. If your company benefits, please c Known issues: -- Remote Execution (RBE) requires the latest version of Bazel, 6.0. Run `echo 6.0.0rc2 > .bazelversion` or set environment `USE_BAZEL_VERSION=6.0.0rc2`. -- With Bazel 6.0.0rc2 and `--remote_download_outputs` set to either `toplevel` or `minimal` there is an [issue](https://github.com/bazelbuild/bazel/issues/16789) with sandboxed execution and tree artifacts (which rules_js uses for the node_modules virtual store). For now it is recommended to not set `--remote_download_outputs` to either `toplevel` or `minimal` with Bazel 6.0.0rc1 & rc2. NB: `--remote_download_outputs` is also set implicitly with the [`--remote_download_minimal`](https://bazel.build/reference/command-line-reference#flag--remote_download_minimal) and [`--remote_download_toplevel`](https://bazel.build/reference/command-line-reference#flag--remote_download_toplevel) flags so these should be avoided as well until the [issue](https://github.com/bazelbuild/bazel/issues/16789) is resolved in Bazel. - > UPDATE: the [fix](https://github.com/bazelbuild/bazel/pull/16812) has landed in Bazel and you can now use `--remote_download_outputs` `toplevel` or `minimal` with Bazel `last_green`. The fix commit should be cherry-picked into the next 6.0.0rc or 6.0.0 final if that is next. +- Remote Execution (RBE) requires the latest version of Bazel, 6.0. Run `echo 6.0.0rc3 > .bazelversion` or set environment `USE_BAZEL_VERSION=6.0.0rc3`. +- `--remote_download_outputs` set to either `toplevel` or `minimal` has a regression in Bazel 6.0.0rc1 and 6.0.0rc2 + due to https://github.com/bazelbuild/bazel/issues/16789. The fix is included in Bazel 6.0.0rc3. - Building docker containers works, per [this example](https://github.com/aspect-build/rules_js/tree/main/e2e/js_image) however it requires some Starlark code which ought to be in our public API, see https://github.com/aspect-build/rules_js/issues/304 - No examples yet for stamping and publishing npm packages. - ESM imports escape the runfiles tree and the sandbox due to https://github.com/aspect-build/rules_js/issues/362