Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make code pip-installable #1

Open
cthoyt opened this issue Jan 3, 2021 · 6 comments
Open

Make code pip-installable #1

cthoyt opened this issue Jan 3, 2021 · 6 comments
Assignees
Labels
enhancement New feature or request

Comments

@cthoyt
Copy link

cthoyt commented Jan 3, 2021

It would be great for potential users of STONED-SELFIES if it were possible to install the code with pip, and later from PyPI. Would you be willing to accept a PR that does this?

It would involve a bit of re-organize the code into the src/ layout, the addition of a setup.py and setup.cfg file, and the addition of a MANIFEST.in file if the data/ folder should be distributed with the package.

@akshat998 akshat998 self-assigned this Jan 5, 2021
@akshat998 akshat998 added the enhancement New feature or request label Jan 5, 2021
@akshat998
Copy link
Collaborator

Hi Cthoyt,

This is an excellent suggestion for improving! With a few more changes coming soon to the repo., we will certainly add a pip install extension!

Thank you!!

@cthoyt
Copy link
Author

cthoyt commented Jan 5, 2021

@akshat998 thanks for the feedback. I guess you mean that you will take care of it after you make some improvements? Otherwise I'd be happy to send a PR

@akshat998
Copy link
Collaborator

Yup! - - we will add this after the extension :)

@ratthachat
Copy link

Hi @akshat998 , any news on this issue?
Or otherwise @cthoyt could you please consider sending a PR again?

@akshat998
Copy link
Collaborator

@ratthachat: thanks for checking in on this!

Unfortunately, I have not had the time to implement this feature.

@cthoyt: I was wondering if it might be possible for your to help here? A PR would be amazing :)

Thank you for the reminder!

@cthoyt
Copy link
Author

cthoyt commented Sep 30, 2022

TBH, I've lost interest. I was bummed to see so much advertisement about stoned-selfies without more attention payed to packaging and reproducibility earlier on :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants