Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EditBox plugin: Focus lost event should not send data #255

Open
deinhofer opened this issue Jun 12, 2018 · 1 comment
Open

EditBox plugin: Focus lost event should not send data #255

deinhofer opened this issue Jun 12, 2018 · 1 comment
Labels
Priority 3 The issue is nice but only has low priority

Comments

@deinhofer
Copy link
Contributor

When using the EditBox plugin you can enter text into the text field and when you press 'Enter' the text is sent to the output port.

If you press the 'Tab' key the box looses the focus which also sends the data. The same happens if you click onto a button, e.g. 'Enter' which triggers the event listener of the EditBox to send the data.
In such a case sending the data is triggered twice

  1. when focus is lost
  2. when the button is clicked

I generally think it's not useful to send the data when the focus is lost. But to make it backwards compatible, this behaviour should at least be configurable as property.
Should we make a property to turn on/off focusLost event?

@ChrisVeigl do you use the focus lost behaviour anywhere?

@deinhofer deinhofer added Priority 2 The issue is important but not mandatory Priority 3 The issue is nice but only has low priority and removed Priority 2 The issue is important but not mandatory labels Jun 12, 2018
@ChrisVeigl
Copy link
Contributor

as far as i remember, we had several cases where it was useful to send the data when the focus is lost.
i agree it would be good to add a property for configruation (keeping the current behaviour by default)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority 3 The issue is nice but only has low priority
Projects
None yet
Development

No branches or pull requests

2 participants