Tk/Tcl upgrade

[apawlucz-cisco]

Hi!

Thanks for the awesome work you do here, Gregory!

I have one ask though. Would it be possible to bump the tk/tcl version provided from 8.6.12 to 8.6.13 (or 8.6.14 which is the latest 8.6.x release)?

Last bump was with the release 20220222

That was bump 8.6.10 -> 8.6.12. 8.6.12 is almost 2-years old already.

Asking as we're experiencing an issue within our GUI app, which was fixed as part 8.6.13 release.

Thanks!

[apawlucz-cisco]

Just to clarify.

The issue we're currently facing with the latest PBS with tk/tcl 8.6.12 is causing the GUI dialog to not receive mouse events (something like 50% clicks or more are not received at all) on Mac. This issue was fixed in 8.6.13:

Mac: Mouse events not delivered to dialog with global grab.

https://sourceforge.net/p/tcl/mailman/message/37738603/

We managed to build python-build-standalone against tk/tcl 8.6.14 which indeed fixed the issue we observed.

We could post a PR for PSB if that helps.

Please let us know what you think.

[charliermarsh]

I'm happy to review a PR if you want to send one in.

[zanieb]

Greg started in this in #303 and I'm following up in #313 — there's some non-trivial work to do still.

[apawlucz-cisco]

Thanks a lot @zanieb!

[apawlucz-cisco]

Hi @zanieb!

Is there a chance for this to be fixed in a foreseeable future?

[zanieb]

@apawlucz-cisco this is blocked by the Windows failure in the pull request — I don't know how to fix it yet.

[zanieb]

We could split the update into Windows / non-Windows, perhaps.

[apawlucz-cisco]

I can only answer for myself here.

The tk issue we're experiencing doesn't happen on Windows. So for our project shipping updated tk only for non-Windows would solve the problem indeed.