Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LSP: include version on code action responses #12855

Closed
LDAP opened this issue Aug 13, 2024 · 6 comments
Closed

LSP: include version on code action responses #12855

LDAP opened this issue Aug 13, 2024 · 6 comments
Labels
server Related to the LSP server

Comments

@LDAP
Copy link

LDAP commented Aug 13, 2024

Including version on code action responses would prevent outdated code actions being applied if the document has changed in the meantime.

See sublimelsp/LSP-ruff#72
@MichaReiser MichaReiser added the server Related to the LSP server label Aug 13, 2024
@dhruvmanila
Copy link
Member

Can you clarify which "version" key are you talking about here? The CodeAction type doesn't have a version field: https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#codeAction

@dhruvmanila
Copy link
Member

Oh, do you mean the document version in TextDocumentEdit?

@dhruvmanila
Copy link
Member

I think this could be merged into #11730

@LDAP
Copy link
Author

LDAP commented Aug 13, 2024

@rchl

@rchl
Copy link

rchl commented Aug 13, 2024

Yes, document edits is what I meant to say in the other issue.

@dhruvmanila
Copy link
Member

Thanks for confirming. I'll merge this into #11730.

@dhruvmanila dhruvmanila closed this as not planned Won't fix, can't repro, duplicate, stale Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
server Related to the LSP server
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@rchl @MichaReiser @LDAP @dhruvmanila