Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature request: Autofix for none-not-at-end-of-union (RUF036) #15136

Open
Avasam opened this issue Dec 24, 2024 · 1 comment · May be fixed by #15139
Open

Feature request: Autofix for none-not-at-end-of-union (RUF036) #15136

Avasam opened this issue Dec 24, 2024 · 1 comment · May be fixed by #15139
Labels
accepted Ready for implementation fixes Related to suggested fixes for violations help wanted Contributions especially welcome

Comments

@Avasam
Copy link

Avasam commented Dec 24, 2024

I tried out RUF036 (in preview) today in typeshed and it found 140 errors. That would take a long time to fix manually, and I imagine an autofix for this rule should be doable.

As usual, marking it "unsafe" when comments are in the way is fine.

Ruff 0.8.4
Command: ruff check --fix --preview --isolated --select=RUF036
@AlexWaygood AlexWaygood added fixes Related to suggested fixes for violations help wanted Contributions especially welcome accepted Ready for implementation labels Dec 24, 2024
@harupy
Copy link
Contributor

harupy commented Dec 25, 2024

can I work on this?

@harupy harupy linked a pull request Dec 25, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
accepted Ready for implementation fixes Related to suggested fixes for violations help wanted Contributions especially welcome
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Autofix for none-not-at-end-of-union (RUF036) harupy/ruff
3 participants
@Avasam @harupy @AlexWaygood