Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test to ensure correct block fees for Ics20Withdrawal #1382

Open
ethanoroshiba opened this issue Aug 20, 2024 · 0 comments
Open

Add test to ensure correct block fees for Ics20Withdrawal #1382

ethanoroshiba opened this issue Aug 20, 2024 · 0 comments
Assignees
@ethanoroshiba
Labels
sequencer pertaining to the astria-sequencer crate testing

Comments

@ethanoroshiba
Copy link
Contributor

ethanoroshiba commented Aug 20, 2024 •
edited
Loading

Currently, the sequencer app tests for correct block fees on every fee-including action other than Ics20Withdrawal. This is because the action's check_and_execute requires having the IBC channel and ports set, but Penumbra does make the 'channel' module public and its StateWriteExt trait is not publicy re-exported (it is now reexported, should be able to implement after #1389).

astria/crates/astria-sequencer/src/app/tests_block_fees.rs

Line 335 in fbc99f0

// TODO(https://github.com/astriaorg/astria/issues/1382): Add test to ensure correct block fees for ICS20 withdrawal

┆Issue Number: ENG-732
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ethanoroshiba ethanoroshiba

Labels
sequencer pertaining to the astria-sequencer crate testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(sequencer): rework fee reporting astriaorg/astria
1 participant
@ethanoroshiba