Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove allow_attributes false positive exceptions once Rust is updated #1580

Open
ethanoroshiba opened this issue Sep 27, 2024 · 0 comments
Open
Labels
code-quality core pertaining to the astria-core crate

Comments

@ethanoroshiba
Copy link
Contributor

ethanoroshiba commented Sep 27, 2024

After updating to Rust 1.81, I came across a bizarre false positive for clippy::allow_attributes and clippy:allow_attributes_withou_reason:
rust-lang/rust-clippy#13380
rust-lang/rust-clippy#13463

It appears this has been fixed and will be pushed out as of Rust 1.83. We should remove this exception when we upgrade:

#[expect(
clippy::allow_attributes,
clippy::allow_attributes_without_reason,
reason = "false positive"
)]
fn try_from_raw_ref(raw: &Self::Raw) -> Result<Self, Self::Error> {

┆Issue Number: ENG-872

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code-quality core pertaining to the astria-core crate
Projects
None yet
Development

No branches or pull requests

1 participant