Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: separate sequencer testing only utils and utils shared with benchmark feature #1585

Open
ethanoroshiba opened this issue Sep 27, 2024 · 0 comments · May be fixed by #1613
Open

chore: separate sequencer testing only utils and utils shared with benchmark feature #1585

ethanoroshiba opened this issue Sep 27, 2024 · 0 comments · May be fixed by #1613
Assignees
Labels
code-quality sequencer pertaining to the astria-sequencer crate

Comments

@ethanoroshiba
Copy link
Contributor

ethanoroshiba commented Sep 27, 2024

We should figure out a way to get rid of this and the others in this file. Unfortunately, we cannot replace allow inside cfg_attr with expect, since clippy evaluates it even when the benchmark feature is not enabled and errs with unfulfilled_lint_expectations.

#[expect(
clippy::allow_attributes,
clippy::allow_attributes_without_reason,
reason = "allow is only necessary when benchmark isn't enabled"
)]
#[cfg_attr(feature = "benchmark", allow(dead_code))]
pub(crate) fn get_alice_signing_key() -> SigningKey {

┆Issue Number: ENG-877

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code-quality sequencer pertaining to the astria-sequencer crate
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant