We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
We should remove the serde traits on the following types as the functionality is no longer required:
TransactionId
astria-core
Address
Deposit
Proof
astria-merkle
This is effectively reverting commit 3c47298.
Note that removing the impl for Deposit requires replacing it with a Display impl, or potentially a Valuable impl.
Display
Valuable
The Display impl could be implemented as follows:
impl Display for Deposit { fn fmt(&self, formatter: &mut Formatter<'_>) -> std::fmt::Result { write!( formatter, "Deposit[bridge address: {}, rollup id: {}, amount: {}, asset: {}, destination chain \ address: {}]", self.bridge_address, self.rollup_id, self.amount, self.asset, self.destination_chain_address, ) } }
┆Issue Number: ENG-893
The text was updated successfully, but these errors were encountered:
No branches or pull requests
We should remove the serde traits on the following types as the functionality is no longer required:
TransactionId
inastria-core
Address
inastria-core
Deposit
inastria-core
Proof
inastria-merkle
This is effectively reverting commit 3c47298.
Note that removing the impl for
Deposit
requires replacing it with aDisplay
impl, or potentially aValuable
impl.The
Display
impl could be implemented as follows:┆Issue Number: ENG-893
The text was updated successfully, but these errors were encountered: