Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sequencer): updates of validator names #1590

Open
joroshiba opened this issue Sep 27, 2024 · 0 comments · May be fixed by #1608
Open

feat(sequencer): updates of validator names #1590

joroshiba opened this issue Sep 27, 2024 · 0 comments · May be fixed by #1608
Assignees
Labels
sequencer pertaining to the astria-sequencer crate

Comments

@joroshiba
Copy link
Member

joroshiba commented Sep 27, 2024

Currently for sudo driven validator updates, we simply reuse the validator update from cometbft. We should wrap this information inside our own custom action and add the ability to set a name.

In order to do this we will also need to add storage of the validator names within the app state machine. Currently these are only set in genesis, and there is no information app side. We should have this information as well as an ABCI query for it.

Because InitChain (cometbft docs) does not pass this information over to the app side, this could create some oddities of behaivior. It may make sense to pass all validator information through the app state & ignore the validator information stored in genesis to avoid oddities with unset names.

┆Issue Number: ENG-883

@joroshiba joroshiba added the sequencer pertaining to the astria-sequencer crate label Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sequencer pertaining to the astria-sequencer crate
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants