Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure sequencer commitments are stable under serialization #320

Closed
SuperFluffy opened this issue Aug 30, 2023 · 1 comment
Closed

Ensure sequencer commitments are stable under serialization #320

SuperFluffy opened this issue Aug 30, 2023 · 1 comment
Labels
sequencer pertaining to the astria-sequencer crate

Comments

@SuperFluffy
Copy link
Member

SuperFluffy commented Aug 30, 2023

The issue raised in #312 is more general than just tests: how can commitments be constructed and verified not only by the present library, but also by third parties and using different languages? The solution is to either define a stable/deterministic wire format, or by using a spec that promises a stable and deterministic set of bytes like https://borsh.io/

@SuperFluffy
Copy link
Member Author

This issue has been partially circumvented by changing the payload that is being signed to a google.protobuf.Any in #1044. While this does not address the sequencer tests checking for protocol breakage to give false positives, it does address the issue of non-rust code (or rust code with a different prost-version) not encoding a byte-perfect wire payload.

@SuperFluffy SuperFluffy closed this as not planned Won't fix, can't repro, duplicate, stale Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sequencer pertaining to the astria-sequencer crate
Projects
None yet
Development

No branches or pull requests

2 participants