Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise a warning if ra/dec column is not float64 #339

Open
1 of 3 tasks
hombit opened this issue Jun 24, 2024 · 0 comments
Open
1 of 3 tasks

Raise a warning if ra/dec column is not float64 #339

hombit opened this issue Jun 24, 2024 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@hombit
Copy link
Contributor

hombit commented Jun 24, 2024

Feature request

For most types of spatial analysis, users would need double-precision floating-point numbers for coordinates, even if the input catalog has only single-precision. It would be helpful to raise a warning to recommend that users pre-process the data (or write their own file reader) to cast their data to float64.

We could also provide a (non-default?) option to make this conversion. I'm not sure if defaulting this option would be a good idea, as it would change the data and could produce inconsistent dtypes, for example when RA/Dec errors are presented in the catalog.

Before submitting
Please check the following:

  • I have described the purpose of the suggested change, specifying what I need the enhancement to accomplish, i.e. what problem it solves.
  • I have included any relevant links, screenshots, environment information, and data relevant to implementing the requested feature, as well as pseudocode for how I want to access the new functionality.
  • If I have ideas for how the new feature could be implemented, I have provided explanations and/or pseudocode and/or task lists for the steps.
@hombit hombit added the enhancement New feature or request label Jun 24, 2024
@nevencaplar nevencaplar added the good first issue Good for newcomers label Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
Status: No status
Development

No branches or pull requests

2 participants