Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve margin_order selection algorithm #358

Closed
hombit opened this issue Jul 26, 2024 · 1 comment · Fixed by #366
Closed

Improve margin_order selection algorithm #358

hombit opened this issue Jul 26, 2024 · 1 comment · Fixed by #366
Labels
enhancement New feature or request

Comments

@hombit
Copy link
Contributor

hombit commented Jul 26, 2024

No description provided.

@delucchi-cmu
Copy link
Contributor

Would need to change the margin_pixel_k calculation to lookup based on value of margin_threshold

https://github.com/astronomy-commons/hipscat-import/blob/main/src/hipscat_import/margin_cache/margin_cache_arguments.py#L62

@hombit hombit added the enhancement New feature or request label Jul 30, 2024
This was referenced Jul 30, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
HATS / LSDB
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change default margin order astronomy-commons/hats-import
2 participants
@hombit @delucchi-cmu