Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundle a poetry.lock file with the release #362

Closed
delucchi-cmu opened this issue Jul 31, 2024 · 1 comment · Fixed by #381
Closed

Bundle a poetry.lock file with the release #362

delucchi-cmu opened this issue Jul 31, 2024 · 1 comment · Fixed by #381
Assignees

Comments

@delucchi-cmu
Copy link
Contributor

This will enable easier deployment for STSci.

If possible, bubble the implementation up to the LINCC PPT.

@delucchi-cmu
Copy link
Contributor Author

From in-person chat, a reasonable approach may be:

inside /.github/workflows/publish-to-pypi.yml

pip install .
<create poetry.lock>
pip install .[dev]
pytest
<publish to pypi with the poetry.lock file>

This bundles the lock file, and runs the unit tests at publish time (which is a current oversight).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants