-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable filtering in galactic coordinates #196
Comments
Do you have a mathematic idea on how to build a great-circle polygon to contain a Galactic-coordinate box? |
@nevencaplar we actually could do it with a combination of a cone search and polygon filtering. For the galactic longitude For the galactic latitude we may use an intersection of couple of cone searches — center is located in the Northern galactic pole and radii are 90 - b_min and 90 - b_max |
@hombit Do you think this is "simple enough" to do it relatively quickly and "easily"? @mjuric expressed a concern about implementing all different coordinates separately, opting rather for a single solution that could take in many more coordinate systems. Having said, galactic is probably a second most important system, and I am worried about that it might be quite a bit time before we are able to incorporate a general solution. |
@nevencaplar Yes, I think it is "simple enough" even for an arbitrary coordinate system input (while all coordinates of the box corners are in the same system). All we need is to support two cases: "ICRS" and "other", while we could relatively easily implement "other" system if we have a way to convert any coordinates from this system to ICRS |
Enable the user to specify the filtering regions (e.g., box), in galactic coordinates.
Possibly API might be (do they use ra/dec for galactic?):
Catalog.box(ra=(340, 342), dec=(340, 342)), coordinates = 'galactic')
The initial suggestion is to have the galactic coordinates box/region transformed into polygon in Equatorial Coordinate System that is sampled with a ``sufficent'' density. From there use existing functionality.
In case that this turns out to be problematic, report back to consider alternative approaches (via e.g., astropy regions).
Connected with astronomy-commons/hats#152
Before submitting
Please check the following:
The text was updated successfully, but these errors were encountered: