Fix some warnings in test #594
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the warnings about non-rotation transform. There is a comment before both instances to warn future editors.
The problem with this is that astroplan pins to too old of minversion of astropy etc. So we either have to bump minversion or do a version check. Would love to see this clean up go in! Also would have to un-ignore the relevant warnings here: Lines 54 to 57 in bf5e26d Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes two warnings I saw when running tests:
ax.plot_date: fixed by usingax.plotwithdatetime64insteadorigin_mismach="ignore"to those two calculations. There is already a comment about this before both instances and removing the warning avoids end users seeing it and wondering if something is wrong with how they specified coordinates.Fix #603