Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

have timeout for cache #1531

Closed
bsipocz opened this issue Aug 12, 2019 · 4 comments
Closed

have timeout for cache #1531

bsipocz opened this issue Aug 12, 2019 · 4 comments

Comments

@bsipocz
Copy link
Member

bsipocz commented Aug 12, 2019

Would be nice to have a mechanism to invalidate the cache. E.g. when new data is added at the serverside users should be able to automatically get access to that. Whether to achieve that with a timeout (which wouldn't work well right around when the new data is added, and would ignore cache unnecessary when there is no data added for a long time) or my some other means is up for discussion.

@bsipocz bsipocz changed the title timeout for cache have timeout for cache Aug 12, 2019
@bsipocz
Copy link
Member Author

bsipocz commented Sep 10, 2019

A caching issue came up again on a twitter thread, this time regarding the jplhorizon module (where ephemeris got updated server side, yet the cached version got used in the query).

I marked both cache related issues (#1511) as critical for the next release, and I feel this should be resolved sooner rather than later.

@keflavich
Copy link
Contributor

We have yet another affected module.

Much as I love caching, maybe we need to start defaulting it to 'off' to circumvent these issues?

@bsipocz
Copy link
Member Author

bsipocz commented Feb 11, 2020

@ceb8 has resurrected the old cache timeout PR in #1634, I'll try to review what she has there soonish instead of changing the defaults.

@bsipocz
Copy link
Member Author

bsipocz commented Nov 10, 2022

#1634 meant to address this, reopen if it's not the case.

@bsipocz bsipocz closed this as completed Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants