Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No way to reject outlierss in doing overscan fit #722

Open
mwcraig opened this issue Dec 24, 2019 · 0 comments
Open

No way to reject outlierss in doing overscan fit #722

mwcraig opened this issue Dec 24, 2019 · 0 comments

Comments

@mwcraig
Copy link
Member

mwcraig commented Dec 24, 2019

As reported by @tapio-not:

I encountered a new issue with the astropy/ccdproc, specifically
subtract_overscan.

The "problem" is that the data I have has occasional bad first line
with values of 4e9 instead of about 10 000 (ADU). This is a CCD-controller
issue, so I just have to live with that.

So, if I fit " models.Polynomial1D(1)" this fails because I have not found
"sigma clipping" option in this "task" as with iraf/ccdproc there is
"Low and high sigma rejection factors for rejecting deviant
points from the overscan fit."

Of course I can replace the 4e9 values with something smaller, but much
more elegant solution would be to have "sigma clipping" while fitting the
data. I guess that using "NDData uncertainty" could do the job,
but I'm not familiar enough with that and anyway this might be an
overkill in comparison to reject one/few points from a fit.

@mwcraig mwcraig added this to the 2.1.1 milestone Dec 24, 2019
@mwcraig mwcraig modified the milestones: 2.1.1, 2.2.0 Mar 15, 2021
@mwcraig mwcraig modified the milestones: 2.2.0, 2.2.1 May 25, 2021
@mwcraig mwcraig modified the milestones: 2.2.1, 2.3 Nov 21, 2021
@mwcraig mwcraig modified the milestones: 2.3, 3.0 Jan 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant