We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Combiner.sigma_clipping
astropy==6.1.4 ccdproc==2.4.2 numpy==2.1.2
The current implementation of Combine.sigma_clipping overwrites any existing mask. Is that intended?
Combine.sigma_clipping
I.e., instead of:
self.data_arr.mask = sigma_clip(self.data_arr.data, sigma_lower=low_thresh, sigma_upper=high_thresh, axis=kwd.get('axis', 0), copy=kwd.get('copy', False), maxiters=kwd.get('maxiters', 1), cenfunc=func, stdfunc=dev_func, masked=True, **kwd).mask
would it make sense to instead do:
self.data_arr.mask |= sigma_clip(self.data_arr.data, sigma_lower=low_thresh, sigma_upper=high_thresh, axis=kwd.get('axis', 0), copy=kwd.get('copy', False), maxiters=kwd.get('maxiters', 1), cenfunc=func, stdfunc=dev_func, masked=True, **kwd).mask
If so, I can submit a short PR.
The text was updated successfully, but these errors were encountered:
Good catch, I think you are right
Sorry, something went wrong.
No branches or pull requests
astropy==6.1.4
ccdproc==2.4.2
numpy==2.1.2
The current implementation of
Combine.sigma_clipping
overwrites any existing mask. Is that intended?I.e., instead of:
would it make sense to instead do:
If so, I can submit a short PR.
The text was updated successfully, but these errors were encountered: