-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add documentation and tests for setup_helpers.pkg_config #5
Comments
The function is simple enough, so I'm not sure if it is worth changing, but there is a python package wrapping pkg-config: https://github.com/matze/pkgconfig |
Oh interesting! Actually if we want to go down that road I suggest we just remove that from extension-helpers and have packages add pkgconfig to their pyproject.toml and use it directly. Is there any reason not to do that? |
Oh yes indeed, that would be even simpler. |
👍 for removing everything we can 😀 |
I won't have time to investigate this in the near future, but if one of you has time to take a look, feel free to open a PR to astropy core to demonstrate how we could use the pkgconfig package instead! |
The
setup_helpers.pkg_config
function is used in several of astropy'ssetup_package.py
files, so we should keep it here, but it isn't tested or documented, so that will need to be fixed.The text was updated successfully, but these errors were encountered: