Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension sending invalid queries to Apollo studio #109

Open
mattoni opened this issue Jul 20, 2022 · 2 comments
Open

Extension sending invalid queries to Apollo studio #109

mattoni opened this issue Jul 20, 2022 · 2 comments
Assignees

Comments

@mattoni
Copy link

mattoni commented Jul 20, 2022

It appears that using fragment queries with this extension attaches an extra } to the end of the fragment portion when sending to Apollo Studio, causing parse errors for the vast majority of my queries. Here's an example of what I see in Apollo Studio:

image

And the query in question:

fragment missingCaps on MissingCapabilities {
  __typename
  message
  required
  oneof
}
fragment pilot on Pilot {
  id
  name
}

fragment catchAll on Error {
  __typename
  message
}
query pilotList {
  operatorList(role: ROLE_PILOT) {
    ... on SpecificOperatorConnection {
      edges {
        node {
          __typename
          ...pilot
        }
        __typename
      }
      __typename
    }
    ...missingCaps
    ...catchAll
    __typename
  }
}

And what Apollo Studio sees:

fragment missingCaps on MissingCapabilities{ __typename message required oneof }} fragment pilot on Pilot{ id name }} fragment catchAll on Error{ __typename message }} query pilotList { operatorList(role: ROLE_PILOT) { ... on SpecificOperatorConnection { edges { node { __typename ... pilot } __typename } __typename } ... missingCaps ... catchAll __typename } }

Every fragment has a } added into it causing the issue.

@Miaxos Miaxos self-assigned this Jul 21, 2022
@Miaxos
Copy link
Member

Miaxos commented Jul 21, 2022

I'll have time to fix it this week-end

@mattoni
Copy link
Author

mattoni commented Aug 12, 2022

Any update on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants