fix Sidebar.tsx #1110
fix Sidebar.tsx #1110
Conversation
fixed undefined name to id
parthikjadav
requested review from
magicmatatjahu,
fmvilas,
asyncapi-bot-eve and
AceTheCreator
as code owners
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
|
We require all PRs to follow Conventional Commits specification. |
|
There was a problem hiding this comment.
Please fix your PR title to follow the conventional commit specification.
https://github.com/asyncapi/asyncapi-react/blob/master/CONTRIBUTING.md
| @@ -39,9 +39,10 @@ export const Sidebar: React.FunctionComponent = () => { | |||
| <ul className="text-sm mt-2"> | |||
| {messages.map((message, index) => ( | |||
| <li key={`menu-message-list-${message.name() ?? index}`}> | |||
| // fixed the href message.name() to message.id() to fix undifined name | |||
There was a problem hiding this comment.
Kindly get rid of this comment :)
fixed this issue #1109
Description
Changes proposed in this pull request:
The anchor link for a message in the sidebar does not work as expected when message.name() and message.id() differ.
Expected result
Clicking on a message in the sidebar should set the correct hash in the URL and scroll the message into view.
Actual result
The anchor link only works if message.name() and message.id() are identical.
If message.name() is not provided, the hash becomes #message-undefined.
before
after
