chore: add devcontainer (#713) #714
Conversation
j-h-a
requested review from
magicmatatjahu,
derberg,
fmvilas and
asyncapi-bot-eve
as code owners
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
|
Kudos, SonarCloud Quality Gate passed!
|
| @@ -0,0 +1,3 @@ | |||
| FROM mcr.microsoft.com/devcontainers/typescript-node:0-16 | |||
|
|
|||
| RUN npm install -g [email protected] | |||
There was a problem hiding this comment.
if node is there, then npm is there for sure
also docs for the base image mention npm https://github.com/devcontainers/images/blob/main/build/README.md?plain=1
is it necessary do to the installation of npm anyway?
|
This pull request has been automatically marked as stale because it has not had recent activity 😴 It will be closed in 120 days if no further activity occurs. To unstale this pull request, add a comment with detailed explanation. There can be many reasons why some specific pull request has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model. Let us figure out together how to push this pull request forward. Connect with us through one of many communication channels we established here. Thank you for your patience ❤️ |
|
no more long living release branches! sorry for any trouble with your PR 😞 but we really had to finally release this v1 and get rid of release branch I close this PR as I think it is better for you to recreate a new fresh PR targeting PS. I love the concept of devcontainer and hope you can continue your work |
Description
The development environment (Node, TypeScript, and npm) is now represented in a devcontainer.
Related issue(s)
Resolves #713