fix: array schema is not being parsed correctly #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a object instead of a LinkedHashMap. If it is an array of schemas, then it will be returned as an arraylist ( like before)
…f Schemas. Updated tests.
# Conflicts: # asyncapi-core/src/test/resources/json/v3/3.0.0/model/channel/message/messageWithArrayPayloadArrayOfSchemas.json # asyncapi-core/src/test/resources/json/v3/3.0.0/model/channel/message/messageWithArrayPayloadJsonSchema.json
…, as we have currently implemented the array schema parsing only for v2.6.0.
…ct or list of schemas) in v3.
jaydeepk
requested review from
Pakisan,
asyncapi-bot-eve and
derberg
as code owners
jaydeepk
changed the title
jaydeepk
changed the title
Pakisan
approved these changes
Oct 14, 2023
Pakisan
merged commit 5f12b19
into
asyncapi:1.0.0-EAP-3-SNAPSHOT
19 of 20 checks passed
|
Original PR: #156 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes parsing of messages where payload is an array:
if 'items' is an object, it will parsed into a Schema object.
If 'items' is defined as an array of schemas, it will parsed into a list of schemas.
Related issue(s)
Resolves #154