Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AsyncAPI spec v3 support in Modelina #1376

Closed
4 tasks done
Tracked by #691 ...
jonaslagoni opened this issue Jun 5, 2023 · 17 comments
Closed
4 tasks done
Tracked by #691 ...

AsyncAPI spec v3 support in Modelina #1376

jonaslagoni opened this issue Jun 5, 2023 · 17 comments
Labels
enhancement New feature or request released on @next

Comments

@jonaslagoni
Copy link
Member

jonaslagoni commented Jun 5, 2023

Reason/Context

This Issue is used to track changes needed to support AsyncAPI v3. As a code owner, please edit this list of TODO tasks in order to properly track the progress 🙂 Once this issue is closed it means that v3 is now fully supported in this library.

Remaining tasks:

@smoya
Copy link
Member

smoya commented Aug 25, 2023

@jonaslagoni can you please add the following task to the list?

- [ ] https://github.com/asyncapi/modelina/issues/1493

@asyncapi-bot
Copy link
Contributor

🎉 This issue has been resolved in version 3.0.0-next.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@jonaslagoni
Copy link
Member Author

Still need to update CLI

@krelde
Copy link

krelde commented Jan 11, 2024

Do you/you have any estimate on when the CLI dependency will be updated?

@jonaslagoni
Copy link
Member Author

@krelde probably in the end of the month when v3 of Modelina is out 🙂

@ignacio-nyt
Copy link

Thanks!

@Elnee
Copy link

Elnee commented Feb 8, 2024

What about mentioning here the issue related to the CLI update?
asyncapi/cli#629

@jonaslagoni
Copy link
Member Author

Should be fixed as soon as asyncapi/cli#1155 is merged

@asyncapi-bot
Copy link
Contributor

🎉 This issue has been resolved in version 4.0.0-next.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@jonaslagoni
Copy link
Member Author

Or #1785 is merged before.

@gegorov
Copy link

gegorov commented Feb 29, 2024

guys, thanks a lot for the great work you doing for the community. Is there any chance to know what are the estimates when asyncapi/cli will fully support 3.0.0 specs and specifically typescript types generation out of asyncapi.yaml as current version as there is still hard check in cli
https://github.com/asyncapi/cli/blob/71b45b4c176e6ea3949d1569dfd9ef776d85657f/src/commands/generate/models.ts#L174

@jonaslagoni
Copy link
Member Author

Honestly, it's hard to guess, there are a few scenarios that are running in parallel right now.

  1. Modelina gets its own CLI: feat: add Modelina CLI #1849
  2. AsyncAPI CLI gets updated: feat: enable v3 and scala for model generation cli#1155

Which ever comes first will enable v3 🤷

@jonaslagoni
Copy link
Member Author

Modelina has it's own CLI install it through @asyncapi/modelina-cli or see https://github.com/asyncapi/modelina/tree/next/modelina-cli, and the AsyncAPI at some point is gonna be updated to support AsyncAPI v3 for model generation, depending on the maintainers.

Closing.

@black-snow
Copy link

@jonaslagoni I can't really follow. Does Modelina understand AsyncAPI v3 now? The readme doesn't reflect that. Only if I don't use the asyncapi CLI and rather the Modelina CLI? Could you elaborate please? :)

@pdalfarr
Copy link

pdalfarr commented Jun 4, 2024

Hi,
I search the doc, but could not find a way to generate model for asyncapi v3 files.
Is this supported or not?
Many AsyncAPI v3 issues are 'closed' here.. so this means this feature is available?

@jonaslagoni
Copy link
Member Author

Right now you can do the following to generate models for AsyncAPI v3 (at least until the AsyncAPI Cli gets updated)npm install -g @asyncapi/[email protected]

Then run it like with the AsyncAPI CLI: modelina generate xxx

@pdalfarr
Copy link

@jonaslagoni it works: thanks a lot :-)
Any idea about [email protected] 's ETA ?

Also, this question, a bit off topic.. I hope you don't mind, I'm asking you this:
I am trying to create an asyncapi.yaml file starting from really simple Java Spring RabbitMQ code, but I am a bit lost.
Can I kindly ask you to help me find the resources / pointers that could bring some light to me regarding that matter?
The full question is here:
https://stackoverflow.com/questions/78581918/async-api-bare-minimum-asyncapi-yaml-for-simple-rabbitlistener

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request released on @next
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants