Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java: enable nullable models doesn't support double #1438

Closed
dlkj opened this issue Jul 11, 2023 · 4 comments
Closed

Java: enable nullable models doesn't support double #1438

dlkj opened this issue Jul 11, 2023 · 4 comments
Labels
bug Something isn't working stale

Comments

@dlkj
Copy link
Contributor

dlkj commented Jul 11, 2023

Describe the bug

Nullable models, implemented by #1141 doesn't support doubles correctly

How to Reproduce

Properties that are non-nullable and of type float should create a property of double not Double when rendering java models.

This can be seen on multiple tests including test/generators/java/__snapshots__/JavaGenerator.spec.ts

Expected behavior

double should be used for non-nullable floats

@dlkj dlkj added the bug Something isn't working label Jul 11, 2023
@github-actions
Copy link
Contributor

Welcome to AsyncAPI. Thanks a lot for reporting your first issue. Please check out our contributors guide and the instructions about a basic recommended setup useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

Copy link
Contributor

github-actions bot commented Nov 9, 2023

This issue has been automatically marked as stale because it has not had recent activity 😴

It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation.

There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here.

Thank you for your patience ❤️

@github-actions github-actions bot added the stale label Nov 9, 2023
@jonaslagoni
Copy link
Member

@dlkj I guess this have been fixed right?

@dlkj
Copy link
Contributor Author

dlkj commented Nov 9, 2023

Yes, fixed by #1439

@dlkj dlkj closed this as completed Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working stale
Projects
None yet
Development

No branches or pull requests

2 participants