Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visual Designer: Form component #752

Closed
Tracked by #748
Amzani opened this issue Jul 31, 2023 · 9 comments · Fixed by #773
Closed
Tracked by #748

Visual Designer: Form component #752

Amzani opened this issue Jul 31, 2023 · 9 comments · Fixed by #773
Assignees

Comments

@Amzani
Copy link
Collaborator

Amzani commented Jul 31, 2023

Add the form component into the design system

The Form component represents a document section containing interactive controls for submitting information

Screenshot 2023-07-31 at 14 56 59

Out of scope

  • The ChipInput component
Screenshot 2023-07-31 at 15 00 34

As part of this PR you might decide to create other components like "DropDown" for instance

Related to #748

@KhudaDad414
Copy link
Member

This form should be generative right? I mean it should get a json schema and generate a form based on that. plus we could combine the AsyncAPI fields with binding to get a comprehensive list of editable properties.
Imma pick this one up. 😄

@KhudaDad414 KhudaDad414 self-assigned this Jul 31, 2023
@KhudaDad414
Copy link
Member

/progress 10
tested if https://github.com/rjsf-team/react-jsonschema-form is the right fit and it doesn't seem to be the right solution for us for the following reasons:

  • it is UI Framework bound which means no tailwind to customise.
  • Our schemas for AsyncAPI file and bindings are not fit for this purpose.
  • It can't be used in server components.

@Amzani
Copy link
Collaborator Author

Amzani commented Aug 2, 2023

@KhudaDad414 I recommend going with the static approach to have more control customisation of form inputs.

@KhudaDad414
Copy link
Member

/progress 10

Added SingleSelect component.

@KhudaDad414
Copy link
Member

/progress 15

Added the TextInput component.

@KhudaDad414
Copy link
Member

/progress 60
The PR is ready for review.

@KhudaDad414
Copy link
Member

/progress 90
The PR is ready for review.

@Amzani Amzani moved this from Backlog to In review in Studio - Kanban Feb 16, 2024
Copy link

This issue has been automatically marked as stale because it has not had recent activity 😴

It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation.

There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here.

Thank you for your patience ❤️

@github-actions github-actions bot added the stale label Feb 22, 2024
@Amzani
Copy link
Collaborator Author

Amzani commented Feb 26, 2024

still relevant.

@github-actions github-actions bot removed the stale label Feb 27, 2024
@github-project-automation github-project-automation bot moved this from In review to Done in Studio - Kanban May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants