Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define the technical solution for PR KPIs #805

Closed
Tracked by #802
Amzani opened this issue Oct 4, 2023 · 11 comments
Closed
Tracked by #802

Define the technical solution for PR KPIs #805

Amzani opened this issue Oct 4, 2023 · 11 comments

Comments

@Amzani
Copy link
Collaborator

Amzani commented Oct 4, 2023

Related to #802

@Amzani
Copy link
Collaborator Author

Amzani commented Oct 4, 2023

/progress 10

Figuring out the technical solution

@asyncapi-bot asyncapi-bot mentioned this issue Oct 4, 2023
3 tasks
@Amzani
Copy link
Collaborator Author

Amzani commented Oct 6, 2023

/progress 15
Exploring https://pullpo.io/app/metrics/

@Amzani
Copy link
Collaborator Author

Amzani commented Oct 6, 2023

/progress 30

Tested https://pullpo.io/app/metrics/, it's too much of what we want to do for now, their slack integration creates a slack channel for each PR and this will create a lot of noise for the code owners.
I've started a script that compute the metrics for a given repo including the p25, p50 and p75, still need some refinement.

@Amzani
Copy link
Collaborator Author

Amzani commented Oct 9, 2023

We are not that bad in studio, I've computed the percentiles for the last merged 100 PRs (excluding automerges and bots).

feature_lead_time
P25 11.0 hours, 34.0 minutes, 16.0 seconds
P50 1.0 day, 18.0 hours, 43.0 minutes, 33.0 seconds
P75 4.0 days, 3.0 hours, 4.0 minutes, 11.0 seconds

pr_lead_time metric
P25 11.0 hours, 31.0 minutes, 54.0 seconds
P50 1.0 day, 20.0 hours, 4.0 minutes, 25.0 seconds
P75 6.0 days, 6.0 hours, 14.0 minutes, 1.0 second


time_to_first_review metric
P25 29.0 minutes, 46.0 seconds
P50 2.0 hours, 49.0 minutes, 3.0 seconds
P75 17.0 hours, 43.0 minutes, 45.0 seconds

last_review_to_merge_time metric
P25 3.0 minutes, 20.0 seconds
P50 7.0 minutes, 44.0 seconds
P75 2.0 hours, 33.0 minutes, 13.0 seconds

@fmvilas @KhudaDad414 how theses metrics sounds for you ?

@Amzani
Copy link
Collaborator Author

Amzani commented Oct 9, 2023

/progress 35

Checking metrics validity and visualising them using chartjs

@smoya
Copy link
Member

smoya commented Oct 10, 2023

creates a slack channel for each PR and this will create a lot of noise for the code owners.

But that's only one part of the product, isn't? Can't we just take the part of the metrics?
The creators of pullpo contacted me offering us a demo session if we want to share our use case and see how they could help. Just in case you are interested.

@Amzani
Copy link
Collaborator Author

Amzani commented Oct 11, 2023

The solution I have in mind if we decide to build something, however I'm still considering using an existing solution.

Screenshot 2023-10-10 at 18 49 41

cc @fmvilas @smoya @KhudaDad414

@Amzani
Copy link
Collaborator Author

Amzani commented Oct 11, 2023

@smoya sure, let's take the opportunity to see the demo

@Amzani
Copy link
Collaborator Author

Amzani commented Oct 11, 2023

/progress 40

Exploring https://github.com/marketplace/actions/issue-metrics

@Amzani
Copy link
Collaborator Author

Amzani commented Oct 11, 2023

/progress 50

Issues metrics looks great so far, this is an example of generated report shapeitapp/shapeitapp#61
Waiting for review of #815 to check studio metrics of the last month

@Amzani
Copy link
Collaborator Author

Amzani commented Oct 23, 2023

/progress 100

Decided to go with https://pullpo.io/, we will make a setup in some repositories.

@Amzani Amzani closed this as completed Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants