-
-
Notifications
You must be signed in to change notification settings - Fork 632
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clicking on specification menu somtimes highlight incorrect item #1452
Comments
So AsyncAPI Object comes under Scheme so should the Scheme also be highlighted when it's sub topics is clicked or only it the subtopics like AsyncAPI Object should be highlighted. |
We are not talking about wanting to highlight
|
@jonaslagoni It would only be highlighted when someone clicks on it or it is in it's corresponding div section, right? However, the Schema and AsyncAPI Object may contain different amounts of information, so when a user is in their respective div sections, both may be highlighted depending on the amount of content in each. I apologize for any confusion my previous response may have caused. |
Yes.
No, there is always just one being highlighted, even if both is in view 🙂 |
So in this issue I would look on highlighting the |
Correct @Savio629 👍 |
I'll start working on it! |
@jonaslagoni |
@Savio629 I would ping the codeowners for that question 🙂 |
@jonaslagoni we can close this issue now |
@sambhavgupta0705 I feel we can close this issue now.... |
Yes ,@jonaslagoni |
Describe the bug
When clicking on something like
AsyncAPI Object
I would expect that menu to be highlighted insteadSchema
is. https://www.asyncapi.com/docs/reference/specification/v2.6.0#A2SObjectThis only happens for some of the links not all.
I have a feeling it's because the article displaying the spec does not take into account the menu is floating once you start scrolling. This means that when I click on
AsyncAPI Object
I am scrolled to an offset position in the document, instead of placing it in the top of the document, because well there is the menu, hiding the text.However, the highlighter does not take this into consideration and still finds the nearest heading based on the top of the document, under the menu itself, i.e. finding
Schema
in this case to be the most likely heading to highlight.The text was updated successfully, but these errors were encountered: