Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[📑 Docs]: improve adeo case study #1615

Closed
1 task done
derberg opened this issue Apr 26, 2023 · 6 comments · Fixed by #1617 or #1941
Closed
1 task done

[📑 Docs]: improve adeo case study #1615

derberg opened this issue Apr 26, 2023 · 6 comments · Fixed by #1617 or #1941
Labels

Comments

@derberg
Copy link
Member

derberg commented Apr 26, 2023

What Dev Docs changes are you proposing?

We have case study https://www.asyncapi.com/casestudies/adeogroup

Code of Conduct

  • I agree to follow this project's Code of Conduct
@derberg derberg added good first issue Good for newcomers 📑 docs labels Apr 26, 2023
@mediba123
Copy link

Update links: All links in the adeo.yml and asyncapi.yaml files that point to https://deploy-preview-921--asyncapi-website.netlify.app/ should be changed to https://asyncapi.com/.

@janvi01
Copy link
Contributor

janvi01 commented Apr 27, 2023

Hey @derberg I would like to work on this.

@AnimeshKumar923
Copy link
Contributor

AnimeshKumar923 commented May 8, 2023

I don't think this part has been resolved, as I've done nothing to this part of the issue. I currently don't have the required knowledge to work upon this. Require assistance...

@derberg derberg reopened this May 24, 2023
@derberg
Copy link
Member Author

derberg commented May 24, 2023

2nd bullet point not implemented yet

SumantxD added a commit to SumantxD/website that referenced this issue May 24, 2023
* completed the second bullet point
@derberg
Copy link
Member Author

derberg commented Jul 13, 2023

@AnimeshKumar923 do you want to try to do it?

what basically has to be done is this versioning should be changed from one-line-string to multi-line-string

here you have an example of multiline string with code sample and the same has to be done. So current text:

Versioning is based on git tags. The schema version pushed to Confluent Schema Registry 
matches the git tag version of the product. Every schema has a `version` information 
that matches with product tag version.

and we need:

Versioning is based on git tags. The schema version pushed to Confluent Schema Registry 
matches the git tag version of the product. Every schema has a `version` information 
that matches with product tag version.

Example Avro schema with version information:
    ```json
    {
      "namespace": "com.adeo.casestudy.costingrequest",
      "type": "record",
      "name": "CostingRequestPayload",
      "version": "1.1.0",
      "fields": [ ... ]
    }
    ```

does that help?

@AnimeshKumar923
Copy link
Contributor

@derberg

  • Let me try that.
  • Thank you for assistance.
  • Will update about it.

AnimeshKumar923 added a commit to AnimeshKumar923/asyncapi-website that referenced this issue Jul 13, 2023
Changes made:
- This PR resolves the second bullet of issue asyncapi#1615.
AnimeshKumar923 added a commit to AnimeshKumar923/asyncapi-website that referenced this issue Jul 13, 2023
Changes made:
	- This PR fixes the second bullet point of asyncapi#1615.
AnimeshKumar923 added a commit to AnimeshKumar923/asyncapi-website that referenced this issue Jul 13, 2023
Previous changes:
- This PR fixes the second bullet point of asyncapi#1615.

Changes in this commit:
- Fix the line containing `validation` on line 90
  that I accidently deleted. :(
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants