Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[📑 Docs]: Adapt Create AsyncAPI document tutorial for v3 #1861

Closed
jonaslagoni opened this issue Jun 28, 2023 · 10 comments · Fixed by #2304
Closed

[📑 Docs]: Adapt Create AsyncAPI document tutorial for v3 #1861

jonaslagoni opened this issue Jun 28, 2023 · 10 comments · Fixed by #2304
Assignees
Labels
area/docs Specify what technical area given issue relates to. Its goal is to ease filtering good first issues. 📑 docs good first issue Good for newcomers

Comments

@jonaslagoni
Copy link
Member

For AsyncAPI v3, we need to adapt the AsyncAPI Documents tutorial (https://www.asyncapi.com/docs/tutorials/create-asyncapi-document) to be usable with AsyncAPI v3.

Here are the v3 structure that should be used instead:

asyncapi: 3.0.0
info:
  title: Streetlights API
  version: '1.0.0'
  description: |
    The Smartylighting Streetlights API allows you
    to remotely manage the city lights.
  license:
    name: Apache 2.0
    url: 'https://www.apache.org/licenses/LICENSE-2.0'

servers:
  mosquitto:
    host: test.mosquitto.org
    protocol: mqtt

channels:
  lightMeasured:
    address: 'light/measured'
    messages:
      lightMeasuredMessage:
        name: LightMeasured
        payload:
          type: object
          properties:
            id:
              type: integer
              minimum: 0
              description: Id of the streetlight.
            lumens:
              type: integer
              minimum: 0
              description: Light intensity measured in lumens.
            sentAt:
              type: string
              format: date-time
              description: Date and time when the message was sent.

operations:
  onLightMeasured:
    action: 'receive'
    summary: Inform about environmental lighting conditions for a particular streetlight.
    operationId: onLightMeasured
    channel:
      $ref: '#/channels/lightMeasured'

Here are the main points that need to change:

  • Re-add the docs/tutorials/create-asyncapi-document.md file.
  • Adapt the AsyncAPI document snippet
  • Adapt the text to match v3 descriptions

Make sure you base your change on the next-major-spec branch and target it in your PR 🙂 If you have any questions, don't hesitate to ask.

@functionguyy
Copy link

@jonaslagoni I'm interested in taking up this task. If no one is assigned to it, can it be assigned to me?

@quetzalliwrites
Copy link
Member

Go for it, @functionguyy! I sent you more instructions in a Slack DM. ✌🏽

@quetzalliwrites quetzalliwrites added good first issue Good for newcomers 📑 docs area/docs Specify what technical area given issue relates to. Its goal is to ease filtering good first issues. labels Jun 29, 2023
@functionguyy
Copy link

Okay, working on it

@functionguyy
Copy link

Hello @jonaslagoni @alequetzalli I just wanted to ask if there is a typo in the operation section for the code block because I have read through the spec v3 doc and can't seem to find anything for the operationId field.

@jonaslagoni
Copy link
Member Author

Yep, you right @functionguyy 🙂

@functionguyy
Copy link

@jonaslagoni Please how do I base my change on the next-major-spec branch for my pull request?

@functionguyy
Copy link

@jonaslagoni @alequetzalli kindly help review my pull request. Thank you.

Copy link

This issue has been automatically marked as stale because it has not had recent activity 😴

It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation.

There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here.

Thank you for your patience ❤️

@github-actions github-actions bot added the stale label Nov 11, 2023
@AnimeshKumar923
Copy link
Contributor

resolved with #2304
@jonaslagoni or @alequetzalli Please close this issue. Don't know why didn't this closed automatically 🤔

@github-actions github-actions bot removed the stale label Nov 12, 2023
@derberg
Copy link
Member

derberg commented Nov 13, 2023

solved with #2304
in next major branch, but considered to be fixed and closing - also for easier management of the scope for v3

@derberg derberg closed this as completed Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docs Specify what technical area given issue relates to. Its goal is to ease filtering good first issues. 📑 docs good first issue Good for newcomers
Projects
Status: Changes proposed 📄
Development

Successfully merging a pull request may close this issue.

5 participants