-
-
Notifications
You must be signed in to change notification settings - Fork 696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify error handling in build-dashboard.js #3305
Comments
Welcome to AsyncAPI. Thanks a lot for reporting your first issue. Please check out our contributors guide and the instructions about a basic recommended setup useful for opening a pull request. |
Working on same will be raising a PR soon.. |
PR #3310 fixes the issue needs a review though.. |
Hello, I noticed this issue and would like to contribute. Is it still open for work? |
As discussed in PR #3304 (comment), @akshatnema agreed to improve the error handling by throwing errors directly instead of using
Promise.reject(e);
in thebuild-dashboard.js
script.We should update the error handling code to throw errors directly, making the asynchronous functions more idiomatic and easier to read.
The text was updated successfully, but these errors were encountered: