Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed rate limiting #3319

Merged
merged 2 commits into from
Oct 23, 2024
Merged

Conversation

akshatnema
Copy link
Member

@akshatnema akshatnema commented Oct 23, 2024

Description

Removed promises from build-dashboard scripts

Testing

Workflow run - https://github.com/akshatnema/website/actions/runs/11479366945

Related issue(s)

Summary by CodeRabbit

  • Bug Fixes

    • Improved the reliability of fetching discussions by transitioning from concurrent to sequential fetching, ensuring more consistent results.
  • Refactor

    • Simplified the fetching logic for discussions while maintaining existing error handling and overall function structure.

Copy link

coderabbitai bot commented Oct 23, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

The changes in this pull request modify the start function in scripts/dashboard/build-dashboard.js. The fetching logic for discussions has been altered from concurrent to sequential calls using await. Issues and pull requests are now fetched one after the other, with their results combined into a single discussions array. Error handling remains unchanged, and the exported module continues to provide the same functions.

Changes

File Change Summary
scripts/dashboard/build-dashboard.js Modified the start function to fetch discussions sequentially instead of concurrently. Error handling remains consistent.

Possibly related PRs

  • fix: fixed dashboard scripts #3304: This PR directly modifies the build-dashboard.js script, specifically the getHotDiscussions function, which is also mentioned in the main PR. Both PRs involve changes to the fetching logic and error handling within the same script.

Suggested reviewers

  • derberg
  • magicmatatjahu
  • devilkiller-ag
  • sambhavgupta0705
  • asyncapi-bot-eve
  • Mayaleeeee
  • anshgoyalevil

🐇 In the garden where discussions bloom,
One by one, they find their room.
Fetching tales, both hot and bright,
Sequential hops bring joy and light.
Errors logged, but spirits high,
A dashboard built to catch the eye! 🌼


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

netlify bot commented Oct 23, 2024

Deploy Preview for asyncapi-website ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 19b2f5a
🔍 Latest deploy log https://app.netlify.com/sites/asyncapi-website/deploys/6718e724a48d1c00081f2e5b
😎 Deploy Preview https://deploy-preview-3319--asyncapi-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Oct 23, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 47.32%. Comparing base (0b09994) to head (19b2f5a).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
scripts/dashboard/build-dashboard.js 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3319      +/-   ##
==========================================
- Coverage   47.46%   47.32%   -0.15%     
==========================================
  Files          22       22              
  Lines         670      672       +2     
==========================================
  Hits          318      318              
- Misses        352      354       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@anshgoyalevil
Copy link
Member

/rtm

@asyncapi-bot
Copy link
Contributor

asyncapi-bot commented Oct 23, 2024

⚡️ Lighthouse report for the changes in this PR:

Category Score
🔴 Performance 42
🟢 Accessibility 98
🟢 Best practices 92
🟢 SEO 100
🔴 PWA 33

Lighthouse ran on https://deploy-preview-3319--asyncapi-website.netlify.app/

@asyncapi-bot asyncapi-bot merged commit adb4832 into asyncapi:master Oct 23, 2024
20 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants