Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Testimonial Alignment Issue on AsyncAPI Website #3509

Open
Pulkitxm opened this issue Dec 22, 2024 · 4 comments · May be fixed by #3515
Open

Testimonial Alignment Issue on AsyncAPI Website #3509

Pulkitxm opened this issue Dec 22, 2024 · 4 comments · May be fixed by #3515
Labels
area/javascript good first issue Good for newcomers

Comments

@Pulkitxm
Copy link

Pulkitxm commented Dec 22, 2024 •
edited
Loading

Description

There is a noticeable misalignment in the testimonials section on the AsyncAPI website. Specifically, Eric Horesnyi's testimonial has excessive spacing between the testimonial text and his image, making it inconsistent with the other testimonials.

Steps to Reproduce

  1. Navigate to the testimonials section of the AsyncAPI website.
  2. Compare the spacing between the testimonial text and image for Eric Horesnyi to the other testimonials.

Expected Behavior

The spacing between the testimonial text and the image should be consistent across all testimonials.

Actual Behavior

Eric Horesnyi's testimonial has significantly more spacing between the testimonial and the image, breaking the visual flow and consistency.

Suggested Fix

Inspect the CSS styling for the testimonials and adjust the margin or padding values for Eric Horesnyi's testimonial to match the others.

Screenshot

image

Are you willing to work on this issue ?

Yes I am willing to submit a PR!
@github-actions GitHub Actions
Copy link

Welcome to AsyncAPI. Thanks a lot for reporting your first issue. Please check out our contributors guide and the instructions about a basic recommended setup useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@Pulkitxm
Copy link
Author

Pulkitxm commented Dec 22, 2024 •
edited
Loading

@akshatnema @Shurtu-gal can you assign it to me?

@reck-coder123 reck-coder123 mentioned this issue Dec 22, 2024
Closed
@Pulkitxm
Copy link
Author

@reck-coder123 I appreciate your contribution, but I noticed you've resolved the issue I created and was already working on. I kindly request you to delete your pull request. In the future, please consider raising your own issues and working on those instead.

@anshgoyalevil
Copy link
Member

anshgoyalevil commented Dec 23, 2024 •
edited
Loading

We don't assign issues here. Feel free to create a PR @Pulkitxm directly.

This was referenced Dec 23, 2024
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/javascript good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
2 participants
@Pulkitxm @anshgoyalevil