Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Will there be a 1.11.2 update? #41

Open
JancxBaron opened this issue Mar 21, 2017 · 6 comments
Open

Will there be a 1.11.2 update? #41

JancxBaron opened this issue Mar 21, 2017 · 6 comments
Assignees

Comments

@JancxBaron
Copy link

Well the title explains it all! I REALLY love this mod, and i am so sad and salty that it isn't updated! Do you think it's possible to get it updated for 1.11.2? <3

@ata4
Copy link
Owner

ata4 commented Mar 26, 2017

I created a branch for 1.11.2, but there are some issues left that I can't fix yet. I have uploaded the branch, in case anyone would like to help.

@ata4 ata4 self-assigned this Mar 26, 2017
@JonL98
Copy link

JonL98 commented Mar 28, 2017

I think I fixed a few things.
In DragonMoveHelper:75, dragon.move(MoverType.SELF, dragon.motionX, dragon.motionY, dragon.motionZ);
In BlockDragonBreedEgg:61, public void getSubBlocks is not an override method
Same for protected void rotateCorpse in DragonRenderer:186
I can't yet figure out the BlockPos issue that came up in the Ice and Forest breeds and DragonBreedHelper, but it looks like it's probably just a name change like the worldObj.

@JonL98
Copy link

JonL98 commented Mar 28, 2017

Actually, I'm not 100% sure about the two override issues, but they did compile.

@ata4
Copy link
Owner

ata4 commented Mar 28, 2017

The strange thing about getSubBlocks and rotateCorpse is that the signatures are still the same for both and they are accessible from within the extending class, yet the compiler complains that they don't actually override anything.

And I remember adding MoverType.SELF to that line as well... I'll check if I forgot to push a commit.

@Sunconure11
Copy link

@ata4 Any news regarding this?

@ghost
Copy link

ghost commented Aug 25, 2017

I could manage to get it compiled for the 1.11.2 version.

Comparing the code of earlier minecraft versions, the method rotateCorpse seems to be moved to RenderLivingBase.applyRotations so when overriding this one instead it worked. Then the signature for getSubBlocks can be fixed as getSubBlocks(Item, CreativeTabs, NonNullList)
Afterwards the mod Id should be changed to have lowercase letters only in DragonMounts.java and in the mcmod.info, otherwise Minecraft will refuse to load the mod.

Then it works and the dragon is rideable. But I didn't test other things, like growing or breeding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants