Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Are ignored path assertions listed/presented as if they're always found? #145

Open
atc0005 opened this issue May 30, 2023 · 1 comment
Open
Assignees
Labels
ignore Related to ignoring specific filesystem or registry paths output/extended Long Service Output (aka, "extended" or "detailed") question Further information is requested
Milestone

Comments

@atc0005
Copy link
Owner

atc0005 commented May 30, 2023

Example from the README file:

C:\Users\Administrator>"C:\Program Files\NSClient++\scripts\custom\check_reboot.exe" --verbose --show-ignored
OK: Reboot not needed (assertions: 15 applied, 0 matched, 1 ignored)

Reboot not required

Assertions ignored:

  - Subkeys for key HKEY_LOCAL_MACHINE/SOFTWARE/Microsoft/Windows/CurrentVersion/WindowsUpdate/Services/Pending found
    subkey: 117cab2d-82b1-4b5a-a08c-4d62dbee7782


 | 'errors'=0;;;; 'evaluated_assertions'=15;;;; 'evaluated_file_assertions'=1;;;; 'evaluated_registry_assertions'=14;;;; 'ignored_assertions'=1;;;; 'matched_assertions'=0;;;; 'time'=1ms;;;;

Is this entry always listed? If so, the way it is presented implies that it was found, but ignored. I need to audit the behavior to make sure that it is only listed if it was found and ignored.

If in the ignore list but not matched, we should handle this differently. Perhaps display a list of ignore entries separately.

@atc0005 atc0005 added question Further information is requested output/extended Long Service Output (aka, "extended" or "detailed") ignore Related to ignoring specific filesystem or registry paths labels May 30, 2023
@atc0005 atc0005 added this to the Future milestone May 30, 2023
@atc0005 atc0005 self-assigned this May 30, 2023
@atc0005
Copy link
Owner Author

atc0005 commented May 30, 2023

Scratch notes from a temporary branch:

func DefaultRebootRequiredIgnoredPaths() []string {
	return []string{

		// FIXME: How are these assertions presented? Are they presented if they're always found?
		/*

				Assertions ignored:

				- Subkeys for key HKEY_LOCAL_MACHINE/SOFTWARE/Microsoft/Windows/CurrentVersion/WindowsUpdate/Services/Pending found
				subpath: 117cab2d-82b1-4b5a-a08c-4d62dbee7782


			This is shown on Windows systems where it is questionable that it was actually found.

		*/
		`SOFTWARE\Microsoft\Windows\CurrentVersion\WindowsUpdate\Services\Pending\117cab2d-82b1-4b5a-a08c-4d62dbee7782`,
	}
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore Related to ignoring specific filesystem or registry paths output/extended Long Service Output (aka, "extended" or "detailed") question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant