Update not accepting request format

[SColson82]

Starting from:
url = "http://67.17.206.205:8080/SDX-Controller"
original payload:
client_name = "Test SDX SC24 L2VPN"
client_endpoints = [
{"port_id": "urn:sdx:port:ampath.net:Ampath2:50", "vlan": "306"},
{"port_id": "urn:sdx:port:tenet.ac.za:Tenet02:50", "vlan": "306"},
]
{'service_id': '720db03e-7a8d-4eaf-8089-04e9bbaa6249'}

I sent the following request to update the l2vpn using the above service_id:
client.update_l2vpn(service_id='720db03e-7a8d-4eaf-8089-04e9bbaa6249', name="new l2vpn")

And received back a 400 response: Failed to update L2VPN. Status code: 400: Request does not have a valid JSON or body is incomplete/incorrect

My understanding is that the user should be able to send the update request using the existing service_id along with any user defined attributes (name, endpoints, description, notifications, scheduling, qos_metrics) - plus the additional option to update the state - that the user wishes to modify. So, I am understanding that if all I wish to modify is the name, the above query should be acceptable.

[congwang09]

This is not supported yet. We need to carefully design this, if we want to simply replace a single field.

Currently if you want to update, use the PATCH API, send the service_id as query param, a new full request as the request body.

[YufengXin]

@SColson82 Thx for the clearly written issue. What you observed is a correct response of the current version:
(1) The required fields in the patch and original requests are the same: specifically "endpoints" is required.
(2) Any changes to the format need to be coordinated with Meican.
(3) Technically, the requests are generated by software, not manually, based on pre-defined templates. So if Meican wants to change its template. We can change accordingly.

Basically, what you suggested makes sense. Please raise it with Meican developers to reach a consensus and let us know, then we can change the parser behavior of SDX-Controller accordingly.

For now, I am tagging this issue "Enhancement", a feature request to be discussed.