Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace post css selector parsing with the official library #200

Closed
itsdouges opened this issue May 26, 2020 · 2 comments · Fixed by #210
Closed

Replace post css selector parsing with the official library #200

itsdouges opened this issue May 26, 2020 · 2 comments · Fixed by #210
Labels
chore 🧹 It's something tedious good first issue 👌 Good for newcomers

Comments

@itsdouges
Copy link
Collaborator

itsdouges commented May 26, 2020

Right now we're parsing it with a string.split - we should move over to the official parsing library instead: https://github.com/postcss/postcss-selector-parser

Code to change: https://github.com/atlassian-labs/compiled-css-in-js/blob/master/packages/ts-transform/src/utils/css-transform.tsx#L30

Now what we have works - so there's no real pressing need to change it. But this is a good first issue I think 😄.


That said looking at some of the issues on there are interesting (like: postcss/postcss-selector-parser#204) - but we probably have the same issue ATM tbh.

@itsdouges itsdouges added chore 🧹 It's something tedious good first issue 👌 Good for newcomers labels May 26, 2020
@pgmanutd
Copy link
Contributor

Good first issue 😋😋Should I start with this 😉 😉

@itsdouges
Copy link
Collaborator Author

Hi! Yeah sure 😄 Give it a go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore 🧹 It's something tedious good first issue 👌 Good for newcomers
Projects
None yet
2 participants