Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix creating item in listened collection #220

Closed
wants to merge 8 commits into from
Closed

Fix creating item in listened collection #220

wants to merge 8 commits into from

Conversation

cedvdb
Copy link
Contributor

@cedvdb cedvdb commented Mar 28, 2022

fix #219,

merge other PR made by me this weekend as this one builds on those

@cedvdb cedvdb mentioned this pull request Mar 28, 2022
Open
atn832
atn832 requested changes Jun 20, 2022
View reviewed changes
Copy link
Owner

@atn832 atn832 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as #218, I'd recommend:

  • rebasing your fixes to master so that they don't depend on your previous commits to unrelated issues
  • writing unit tests to demonstrate what the code does, and prevent others from breaking your change.

Thanks for contributing!

@cedvdb cedvdb closed this Jan 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atn832 atn832 atn832 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cannot watch stream and create at the same time
2 participants
@cedvdb @atn832