Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

Completion items with same text are dropped #113

Closed
nwolverson opened this issue Sep 24, 2017 · 3 comments
Closed

Completion items with same text are dropped #113

nwolverson opened this issue Sep 24, 2017 · 3 comments

Comments

@nwolverson
Copy link
Contributor

If a language server returns multiple completions that get mapped to the same text (but say with different documentation, command/additional edits), some are dropped due to atom/autocomplete-plus#615 - raising here as workarounds have been discussed (that issue and atom/autocomplete-plus#877) - having used one workaround for this which is imperfect I'd rather see an upstream fix.

@damieng
Copy link
Contributor

damieng commented Sep 25, 2017

Will be in the next patch release of Atom 1.12 atom/autocomplete-plus#615

@damieng damieng closed this as completed Sep 25, 2017
@nwolverson
Copy link
Contributor Author

Verified this works with the latest tagged autocomplete-plus.

Super fast change on a long-standing issue! So happy.

@damieng
Copy link
Contributor

damieng commented Sep 25, 2017

Yeah glad that worked out for you. It was actually a very simple change although I'm not 100% convinced it won't upset somebody when the suggestion provider they are using doesn't do its own duplication detection hence the config switch :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants