Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ledger support is disabled in make install #49

Closed
tbruyelle opened this issue Sep 14, 2024 · 2 comments
Closed

Ledger support is disabled in make install #49

tbruyelle opened this issue Sep 14, 2024 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@tbruyelle
Copy link
Collaborator

The reproducible build feature has disabled CGO, but CGO is actually necessary for ledger support.

@tbruyelle tbruyelle added the bug Something isn't working label Sep 14, 2024
@tbruyelle tbruyelle self-assigned this Sep 14, 2024
@tbruyelle
Copy link
Collaborator Author

tbruyelle commented Sep 16, 2024

Interestingly, ledger support is also disabled in gaia releases(*), because like govgen, CGO is disabled (CGO_ENABLED=0) in the goreleaser config. What reproducible build did is to disable CGO in Makefile, ensuring aligned LD_FLAGS between Makefile and goreleaser. So I rename the issue to "Ledger suppor is disabled from Makefile", because it has always been the case for the github binaries generated by goreleaser.

If we remove CGO_ENABLED=0 from the Makefile, we get ledger support from make install (because by default CGO is enabled) but we break reproducible builds.
If we set CGO_ENABLED=1 in both Makefile and goreleaser, we get ledger support but we probably also break reproducible builds as we introduce OS related stuff in the build process (this needs to be checked, but I'm pretty sure it is the case).

An other solution might be to add a new target make install-with-ledger, so we keep reproducible builds between make install and goreleaser, but we provide a way to build a binary with ledger support. I think that's the best solution.

(*) only recent releases of gaia has ledger support, since they had to enable CGO for cosmowasm.

@tbruyelle tbruyelle changed the title Ledger support is disabled Ledger support is disabled from make install Sep 16, 2024
@tbruyelle tbruyelle changed the title Ledger support is disabled from make install Ledger support is disabled in make install Sep 16, 2024
@tbruyelle
Copy link
Collaborator Author

Fixed by #52 which introduces a build-ledger makefile target.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant