-
Notifications
You must be signed in to change notification settings - Fork 3
/
merge_tags.py
204 lines (181 loc) · 7.81 KB
/
merge_tags.py
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
import logging
from nvdb_segment import *
from geometry_basics import calc_way_length
_log = logging.getLogger("tags")
def merge_tags(seg, src, data_src_name):
way = seg.way
dst = seg.tags
src_date = src.get("FRAN_DATUM", 0)
fixmes = []
for k, v in src.items():
if k in NVDB_GEOMETRY_TAGS or k == "FRAN_DATUM":
# ignore special tags
continue
if not k in dst:
# new value
dst[k] = v
seg.tag_src[k] = (data_src_name, src_date)
continue
if k not in seg.tag_src:
seg.tag_src[k] = ("", 18000101)
ov = dst[k]
if isinstance(ov, list):
match = False
for item in ov:
if item == v:
match = True
break
if match:
continue
elif ov == v:
if seg.tag_src[k][1] < src_date:
seg.tag_src[k] = (data_src_name, src_date)
continue
if k == "fixme":
append_tag_value(dst, k, v)
continue
resolved = False
fixme = False
solution = "resolve solution not specified"
# go through tags that can become lists first
if not resolved:
if data_src_name == "NVDB-Vagnummer":
if k == "NVDB_vagnummer":
append_tag_value(dst, k, v)
solution = "list"
resolved = True
elif data_src_name in [ "NVDB-Gatunamn", "NVDB-Ovrigt_vagnamn", "NVDB-Korsning" ]:
if k == "name":
if v is None:
# unusual, but 'None' have been observed
solution = "ignoring 'None'"
else:
# this is normal for roundabouts (names of streets passing through)
append_tag_value(dst, "alt_name", v)
solution = "list"
resolved = True
if not resolved and isinstance(dst[k], list):
fixme = True
resolved = True
fixmes.append("Could not resolve key %s, alt value %s" % (k, v))
# go through things we want to resolve before we look at the date
prio_layers = {
# prioritized layers to the left
"VIS-Slitlager": "NVDB-Slitlager",
"NVDB-GCM_passage": "NVDB-Korsning",
"NVDB-Vagnummer": "NVDB-Gatunamn" # often conflicting value for LANKROLL
}
if not resolved:
if prio_layers.get(data_src_name, None) == seg.tag_src[k][0]:
dst[k] = v
seg.tag_src[k] = (data_src_name, src_date)
resolved = True
solution = "prioritized layer"
elif prio_layers.get(seg.tag_src[k][0], None) == data_src_name:
resolved = True
solution = "prioritized layer"
# resolve by date, if possible
if not resolved:
if seg.tag_src[k][1] != src_date:
if seg.tag_src[k][1] < src_date:
dst[k] = v
seg.tag_src[k] = (data_src_name, src_date)
solution = "date"
resolved = True
# look at specific data sources and keys
if not resolved:
if data_src_name == "NVDB-Gatutyp":
if k == "NVDB_gatutyp":
# if same date, just keep current, not too important and Gatutyp is a bit messy data
solution = "not deemed important, current value kept"
resolved = True
elif data_src_name == "NVDB-Gatunamn":
if k == "NVDB_road_role":
# if same date, just keep current, not too important
solution = "not deemed important, current value kept"
resolved = True
elif data_src_name == "NVDB-Hastighetsgrans":
if k in ("maxspeed", "maxspeed:forward", "maxspeed:backward"):
if ov > v:
dst[k] = v # keep smaller value
solution = "kept smaller value"
resolved = True
elif data_src_name in [ "NVDB-InskrTranspFarligtGods", "NVDB-RekomVagFarligtGods" ]:
# We've seen overlaps of these two layers (Malmö dataset), but as RekomVagFarligtGods is more
# specific we trust that layer more
if k == "hazmat":
if ov != "designated" and v == "designated":
dst[k] = v
solution = "kept designated"
resolved = True
elif data_src_name == "NVDB-Vagbredd":
if k == "width":
if ov > v:
dst[k] = v
solution = "kept smaller value"
resolved = True
elif data_src_name == "NVDB-Gagata":
if k == "NVDB_gagata_side":
if (ov == "left" and v == "right") or (ov == "right" and v == "left"):
dst[k] = "both"
solution = "merged to 'both'"
resolved = True
elif data_src_name == "NVDB-GCM_vagtyp":
if k == "GCMTYP":
gcm_resolve = [
(11, 17, 17), # gångbana 11 => trappa 17
(1, 3, 3), # cykelbana 1 => cykelpassage 3
(1, 4, 4), # cykelbana 1 => övergångsställe 4
(12, 5, 5), # trottoar 12 => gatupassage utan märkning 5
(12, 4, 4), # trottoar 12 => övergångsställe 4
]
for gcm in gcm_resolve:
if (ov == gcm[0] and v) == gcm[1] or (ov == gcm[1] and v == gcm[0]):
dst[k] = gcm[2]
solution = "used GCM resolve table"
resolved = True
break
elif data_src_name == "NVDB-Farthinder":
if k == "traffic_calming":
if ov == "yes" and v != "yes":
dst[k] = v
solution = "used more specific"
resolved = True
elif ov == "choker" and v != "choker" and v != "yes":
dst[k] = v
solution = "prefer other value over choker"
resolved = True
if not resolved and isinstance(way, list):
dist, _ = calc_way_length(way)
if dist < 1.0:
# short segment, we don't care
solution = "short segment (%g), keeping old value" % dist
resolved = True
if not resolved:
fixme = True
resolved = True
fixmes.append("Could not resolve key %s, alt value %s" % (k, v))
if fixme:
res_str = "Warning: not resolved, added fixme tag"
else:
res_str = "Resolved, using %s (%s)" % (dst[k], solution)
if fixme or solution not in ("list", "prioritized layer"):
_log.warning(f"Conflicting value for key '{k}' ('{v}' and '{ov}', RLID {seg.rlid}). {res_str}")
if dst[k] == v and seg.tag_src[k][1] < src_date:
seg.tag_src[k] = (data_src_name, src_date)
for v in fixmes:
append_fixme_value(dst, v)
def append_fixme_value(tags, fixme_value):
if "fixme" not in tags:
fixme_value = "NVDB import: " + fixme_value
append_tag_value(tags, "fixme", fixme_value)
def append_tag_value(tags, k, v):
if k not in tags:
tags[k] = v
return
current = tags[k]
if isinstance(current, list):
if not v in current:
current.append(v)
elif current != v:
tags[k] = [ current, v ]