Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark mode #80

Open
frederickobrien opened this issue Nov 13, 2020 · 0 comments
Open

Dark mode #80

frederickobrien opened this issue Nov 13, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@frederickobrien
Copy link
Member

frederickobrien commented Nov 13, 2020

Big, mostly cosmetic project, though possibly worth keeping an eye on as we improve accessibility on the colour front. Basic in-browser mockup below with a #282828 background.

image

Just browsing a handful of reviews I have a hunch this would mean making custom dark mode color schemes for all reviews. Doable, but not jumping at the idea!

Further reading/resources:

Colours that seemed like solid baselines from playing around in dev tools:

  • Background: #303030
  • Album artwork border: #121212
  • Body copy: White, Opacity 0.87
  • Images: filter: brightness(.8) contrast(1.2); (this creates a whole new headache with review colours matching artwork, though)

Toggle

paulrand.design has a nice approach where the button float on the bottom right of the screen, rather than being shoehorned into the header somewhere.

image

@frederickobrien frederickobrien added the enhancement New feature or request label Nov 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant