Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing a cookie just sets it to empty #7

Open
Truffula opened this issue Dec 2, 2021 · 1 comment · May be fixed by #8
Open

Removing a cookie just sets it to empty #7

Truffula opened this issue Dec 2, 2021 · 1 comment · May be fixed by #8

Comments

@Truffula
Copy link

Truffula commented Dec 2, 2021

Calling Cookies.remove() without any options sets the value to empty, but doesn't actually remove the cookie.

Truffula added a commit to Truffula/aurelia-plugins-cookies that referenced this issue Dec 2, 2021
@Truffula Truffula linked a pull request Dec 2, 2021 that will close this issue
@Truffula
Copy link
Author

Truffula commented Dec 2, 2021

const before = document.cookie;
Cookies.put("foo", "bar");
const middle = document.cookie;
Cookies.remove("foo");
const after = document.cookie;
console.log({before, middle, after})
// Current result:
// {before: '', middle: 'foo=bar', after: 'foo='}
// After fix #8:
// {before: '', middle: 'foo=bar', after: ''}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant